Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-1891] Inlong-Sort-Standalone add sort-standalone-source module. #1930

Merged
merged 1 commit into from
Dec 9, 2021
Merged

[INLONG-1891] Inlong-Sort-Standalone add sort-standalone-source module. #1930

merged 1 commit into from
Dec 9, 2021

Conversation

luchunliang
Copy link
Contributor

@luchunliang luchunliang commented Dec 8, 2021

Title Name: [INLONG-1891][Sort-Standalone] add sort-standalone-source module.

Fixes #1891
Fixes #1894

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov-commenter
Copy link

Codecov Report

Merging #1930 (e32e7a9) into master (fccece5) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1930      +/-   ##
============================================
- Coverage     12.28%   12.27%   -0.02%     
+ Complexity     1159     1157       -2     
============================================
  Files           413      413              
  Lines         35225    35225              
  Branches       5542     5542              
============================================
- Hits           4329     4325       -4     
- Misses        30127    30129       +2     
- Partials        769      771       +2     
Impacted Files Coverage Δ
...bemq/server/common/heartbeat/HeartbeatManager.java 36.36% <0.00%> (-2.03%) ⬇️
.../producer/qltystats/DefaultBrokerRcvQltyStats.java 45.31% <0.00%> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fccece5...e32e7a9. Read the comment docs.

Copy link
Contributor

@gosonzhang gosonzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants